Skip to content
This repository was archived by the owner on Dec 11, 2017. It is now read-only.

Fallback to event.keyCode for firefox#247

Merged
codeimpossible merged 1 commit intodigitalBush:masterfrom
patrickkettner:use-keycode
Oct 17, 2014
Merged

Fallback to event.keyCode for firefox#247
codeimpossible merged 1 commit intodigitalBush:masterfrom
patrickkettner:use-keycode

Conversation

@patrickkettner
Copy link
Contributor

fixes #199

@codeimpossible
Copy link
Collaborator

@patrickkettner thanks for the submission! The changes in the src/jquery.maskedInput.js look fine, however, there are a ton of changes to the javascript in the dist folder.

The dist folder is really only updated when we release a new version. All code modifications should be done to the javascript in the src/ folder, and only changes to the src/ folder should be submitted in a PR.

Can you move your changes from dist/ to src/ and re-submit?

@patrickkettner
Copy link
Contributor Author

done!

@patrickkettner
Copy link
Contributor Author

rebased off of latest master as well

codeimpossible added a commit that referenced this pull request Oct 17, 2014
Fallback to event.keyCode for firefox
@codeimpossible codeimpossible merged commit cc6c112 into digitalBush:master Oct 17, 2014
@FagnerMartinsBrack
Copy link
Contributor

@codeimpossible one should remove dist folder from source control and add into .gitignore, then commit only when release is done by using the command:

$ git add build -f

jQuery has a pattern to automate this using grunt release process (but I never digged deeper into it).

@digitalBush
Copy link
Owner

Good idea on the dist folder. I've been rebuilding that thing every push just so people have a version they can test the changes. Hopefully we can get on a more sane release cycle and make this a non-issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants